RFR: 8324649: Shenandoah: refactor implementation of free set [v39]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Apr 16 00:34:06 UTC 2024


On Wed, 10 Apr 2024 11:26:03 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove debugging instrumentation
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 93:
> 
>> 91:   uintx complement = ~element_bits;
>> 92:   uintx trailing_ones;
>> 93:   if (complement) {
> 
> complement is not a bool type. If you meant to say 'if (complement != 0)' then say so, to make it easier for the reader. Same applies for a few other places.

Thanks.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1566573253


More information about the hotspot-gc-dev mailing list