RFR: 8324649: Shenandoah: replace implementation of free set [v39]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Apr 17 16:13:06 UTC 2024
On Sat, 13 Apr 2024 15:17:07 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 45:
>>
>>> 43: // break abstraction rules, because efficient implementation requires assumptions about superclass internals that
>>> 44: // might be violatee through future software maintenance.
>>> 45: class ShenandoahSimpleBitMap {
>>
>> I think this class should go into its own set of files. It would certainly help readability of ShFreeSet which is now somewhat dominated by ShSimpleBitMap.
>
> Thanks for suggestion. Done.
Thanks. I've separated this code into distinct source files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1569105090
More information about the hotspot-gc-dev
mailing list