RFR: 8330047: ASAN build error with gcc 13
Kim Barrett
kbarrett at openjdk.org
Thu Apr 18 18:03:58 UTC 2024
On Wed, 17 Apr 2024 18:54:30 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:
> Hi all,
>
> This PR addresses [8330047](https://bugs.openjdk.org/browse/JDK-8330047).
>
> This is the workaround suggested in the comments. Might be worthwhile to include this patch as the recommended toolchain version for [building](https://openjdk.org/groups/build/doc/building.html) the JDK is currently gcc 13.2.0.
>
> Testing:
> - [x] Reproduced build failure with gcc 13.2.0.
> - [x] Verified release build is successful after patch with ```--enable-asan```.
>
> Thanks,
> Sonia
I don't think this change should be made. There are two problems exhibited by the
current code. One is that ASAN doesn't seem to properly handle alignas attributes.
The other is that we're misusing alignas attributes. Fixing the latter would both
eliminate the resulting UB and work around the ASAN bug.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18825#pullrequestreview-2009552307
More information about the hotspot-gc-dev
mailing list