RFR: 8330670: Obsolete ScavengeBeforeFullGC

[Stefan Karlsson]

On Fri, 19 Apr 2024 11:53:15 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Obsolete a gc product flag.
> 
> Test: tier1-3

Changes requested by stefank (Reviewer).

src/hotspot/share/gc/z/zDriver.cpp line 313:

> 311:   assert(!should_clear_soft_references(cause), "Clearing soft references without pre-cleaning young gen");
> 312: 
> 313:   return false;

I'm not sure if this is correct. We previously returned true here if the user didn't set ScavengeBeforeFullGC, right? Maybe we need a ZGC-specific flag to allow this "precleaning" to be turned off?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18861#pullrequestreview-2011257486
PR Review Comment: https://git.openjdk.org/jdk/pull/18861#discussion_r1572273009