RFR: 8331094: ZGC: GTest fails due to incompatible Windows version
Stefan Johansson
sjohanss at openjdk.org
Thu Apr 25 10:45:32 UTC 2024
On Thu, 25 Apr 2024 08:59:59 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> Please review this test fix for an intermittent tier1 failure.
>>
>> **Summary**
>> A newly added Windows specific ZGC tests requires some system calls not available on all Windows systems. This fix adds code to the test setup to ensure the required system calls are supported and otherwise skip the test.
>>
>> **Testing**
>> Verified that the test is now skipped if running on a system that is not supported. We get the following output:
>>
>> [----------] 3 tests from ZMapperTest
>> [ RUN ] ZMapperTest.test_alloc_low_address_vm
>> ...\\open\\test\\hotspot\\gtest\\gc\\z\\test_zMapper_windows.cpp(72): Skipped
>> Requires Windows version 1803 or later
>>
>> [ SKIPPED ] ZMapperTest.test_alloc_low_address_vm (0 ms)
>> [ RUN ] ZMapperTest.test_alloc_high_address_vm
>> ...\\open\\test\\hotspot\\gtest\\gc\\z\\test_zMapper_windows.cpp(72): Skipped
>> Requires Windows version 1803 or later
>>
>> [ SKIPPED ] ZMapperTest.test_alloc_high_address_vm (0 ms)
>> [ RUN ] ZMapperTest.test_alloc_whole_area_vm
>> ...\\open\\test\\hotspot\\gtest\\gc\\z\\test_zMapper_windows.cpp(72): Skipped
>> Requires Windows version 1803 or later
>
> lgtm.
Thanks for the reviews @xmas92 and @tschatzl.
I will integrate this right away, to avoid noise in the CI.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18944#issuecomment-2076886284
More information about the hotspot-gc-dev
mailing list