RFR: 8330275: Crash in XMark::follow_array [v3]

[Stefan Karlsson]

On Thu, 25 Apr 2024 06:54:24 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typos
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> Hi @ashu-mehra,
> 
> Thanks for fixing this issue.
> 
> There's a number of changes style changes I would like to make to make sure that the code looks more inline with what the rest of the ZGC code looks like. But before we start with that I would like to request that we skip making the changes to marking stack code and limit the changes to only the probing code. Doing so will make it easier to get this fix reviewed and delivered.

> @stefank I am trying to understand the reason behind your suggestion to remove the changes in marking stack code. Are they not correct or is it that they don't belong to this PR? Anyway I have removed them from this PR.

To me, it was not bleeding obvious that they were the right thing to do, and given other changes that doesn't follow the grown ZGC coding style, I wanted suggest a way forward for you to get this bug fixed, with less resistance from us ZGC developers/maintainers. That was the reasoning.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18941#issuecomment-2078692598