RFR: 8324649: Shenandoah: replace implementation of free set [v45]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Apr 30 02:50:35 UTC 2024


On Tue, 23 Apr 2024 16:05:34 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 227:
> 
>> 225: }
>> 226: 
>> 227: inline void ShenandoahRegionPartitions::shrink_interval_if_boundary_modified(ShenandoahFreeSetPartitionId partition, idx_t idx) {
> 
> This almost looks like a variant of shrink_interval_if_range_modifies_either_boundary(...), maybe it could just call shrink_interval_if_range_modifies_either_boundary(partition, idx, idx)?

Good suggestion.  Thanks.  Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1584060588


More information about the hotspot-gc-dev mailing list