RFR: 8324649: Shenandoah: replace implementation of free set [v45]

[Kelvin Nilsen]

On Tue, 23 Apr 2024 17:11:04 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 401:
> 
>> 399: }
>> 400: 
>> 401: inline idx_t ShenandoahRegionPartitions::find_index_of_next_available_region(
> 
> If I read this correctly, calling code assumes that the result is >= start_index, right? Otherwise loops might not terminate. Maybe assert that this holds?

Good idea.  Done.

> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 413:
> 
>> 411: }
>> 412: 
>> 413: inline idx_t ShenandoahRegionPartitions::find_index_of_previous_available_region(
> 
> Same as above but other way around?

Also done.
Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1584076252
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1584076320