RFR: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx [v9]

Guoxiong Li gli at openjdk.org
Tue Apr 30 15:22:09 UTC 2024


On Tue, 30 Apr 2024 15:11:27 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reverse previous change
>
> src/hotspot/share/gc/shared/genArguments.cpp line 311:
> 
>> 309:     } else if (initial_old_size < MinOldSize) {
>> 310:       log_warning(gc, ergo)("Inconsistency between initial old size and minimum old size");
>> 311:       MinOldSize = initial_old_size;
> 
> The comment shown below seems strange. Can it be removed?
> ```C++
>     // The generation minimums and the overall heap minimum should
>     // be within one generation alignment.
> 
> 
> 
> The warning message shown below can be more consistent with this newly added one. 
> ```C++
>       log_warning(gc, ergo)("Inconsistency between maximum heap size and maximum "
>                             "generation sizes: using maximum heap = " SIZE_FORMAT
>                             ", -XX:OldSize flag is being ignored",
>                             MaxHeapSize);

If you think they are not related to this bug, it is also OK to fix them in another ticket.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18539#discussion_r1585020141


More information about the hotspot-gc-dev mailing list