RFR: 8337642: Serial: Remove redundant counter update in DefNewGeneration::gc_epilogue
Thomas Schatzl
tschatzl at openjdk.org
Thu Aug 1 08:39:32 UTC 2024
On Thu, 1 Aug 2024 07:43:05 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Trivial removing an empty method call. (Only subclasses have non-empty method body, which is not used by Serial.)
I disagree with this change: when using `GCPolicyCounters`, the implied contract seems to be that `update_counters` is called at appropriate locations (e.g. `gc_epilogue`), even if empty, exactly to abstract away differences in the collectors wrt to usage.
Looking at the users, it rather seems G1 being wrong in not calling this.
-------------
PR Review: https://git.openjdk.org/jdk/pull/20416#pullrequestreview-2212007311
More information about the hotspot-gc-dev
mailing list