RFR: 8336299: Improve GCLocker stall diagnostics [v4]

[Neethu Prasad]

On Wed, 24 Jul 2024 08:23:54 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Neethu Prasad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address formating issue and code clean up feedback
>
> src/hotspot/share/gc/shared/gcLocker.cpp line 124:
> 
>> 122:   }
>> 123: 
>> 124:   elapsedTimer elapsed_timer;
> 
> In GC code we tend to use the newer `Ticks` and `Tickspan` API, not `elapsedTimer`. Only Parallel GC uses it at this point afaict (or just `os::elapsedTime()`/`os::elapsed_counter()`).
> 
> Maybe it's even worth to add a special class that can be used with scopes to hide all that including the manual call to `log_debug_jni` (automatically done in the destructor). Probably not really useful.

Addressed in latest revision.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20277#discussion_r1701133766