RFR: 8336299: Improve GCLocker stall diagnostics [v3]

[Neethu Prasad]

On Wed, 31 Jul 2024 08:10:43 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Neethu Prasad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add missing imports and remove unused ones
>
> src/hotspot/share/gc/shared/gcLocker.hpp line 166:
> 
>> 164:   GCLockerTimingDebugLogger(const char* log_message);
>> 165:   ~GCLockerTimingDebugLogger();
>> 166: };
> 
> There should be no code after the include guard on line 153. This class should be moved above it. With that said, this class is only used in gcLocker.cpp, so there's really no need to expose it through the gcLocker.hpp file, AFAICT.
> 
> Also, note that you are using `/* */` to add a comment about the class, but the rest of the code in this file uses `//`, so I'd prefer to see it changed.
> 
> Also note that GitHub complains that your addition lacks a newline at the end of the file. We recently went over the GC code base and fixed issues like that. Maybe there's a way to configure your editor to add one when making edits to the end of a file?

Thanks for the feedback. Addressed in new PR revision.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20277#discussion_r1701134220