RFR: 8336299: Improve GCLocker stall diagnostics [v4]

[Thomas Schatzl]

On Fri, 2 Aug 2024 06:52:53 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Neethu Prasad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address formating issue and code clean up feedback
>
> src/hotspot/share/gc/shared/gcLocker.cpp line 56:
> 
>> 54: 
>> 55:     ~GCLockerTimingDebugLogger() {
>> 56:       const Tickspan elapsed_time = Ticks::now() - _start;
> 
> Why is this outside the `if` logger-enabled check?

Please move within the `if`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20277#discussion_r1701459168