RFR: 8310675: Fix -Wconversion warnings in ZGC code [v2]
Stefan Karlsson
stefank at openjdk.org
Wed Aug 7 13:42:06 UTC 2024
On Wed, 7 Aug 2024 13:39:15 GMT, Joel Sikström <duke at openjdk.org> wrote:
>> Fixed `-Wconversion` warnings in ZGC code, either by adding an explicit type cast, changin the type of the variable or calling an equivalent method with other types. The largest change is the addition of `ZStatDurationSample`, which typecasts `Tickspan::value()` to a `uint64_t` and calls `ZStatSample` to make the code more readable.
>>
>> I isolated the `-Wconversion` warnings for ZGC by adding the flag to clangd and displaying the errors in my IDE and going through each file directly associated with ZGC one by one.
>>
>> Tested with tiers 1-3.
>
> Joel Sikström has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8310675
> - 8310675: Fixed -Wconversion warnings in ZGC
Marked as reviewed by stefank (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/20406#pullrequestreview-2225135283
More information about the hotspot-gc-dev
mailing list