RFR: 8337938: ZUtils::alloc_aligned allocates without reporting to NMT [v2]

Kim Barrett kbarrett at openjdk.org
Mon Aug 12 07:12:37 UTC 2024


On Mon, 12 Aug 2024 06:29:48 GMT, Joel Sikström <duke at openjdk.org> wrote:

>> Replaces usage of posix_memalign/_aligned_malloc with os::malloc and manual alignment to report memory usage to NMT. Manually aligning the memory makes the returned address unfreeable by malloc (as clarified by the added comment), which is reasonable since the memory used by ZUtils::alloc_aligned is never freed.
>> 
>> Tested with tiers 1-3.
>
> Joel Sikström has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into zgc_zutils_alloc_aligned
>  - Updated copyright years
>  - Remove trailing whitespace
>  - 8337938: ZUtils::alloc_aligned allocates without reporting to NMT

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20523#pullrequestreview-2232190875


More information about the hotspot-gc-dev mailing list