RFR: 8337981: ShenandoahHeap::is_in should check for alive regions [v2]
Aleksey Shipilev
shade at openjdk.org
Wed Aug 14 17:58:12 UTC 2024
On Wed, 14 Aug 2024 16:40:13 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Not sure I understand. The if-condition checks that we are pointing into heap. This means `heap_region_containing` always returns the region.
>
> heap_region_containing() returns the region for which bottom <= p < end, my question is if we should check if bottom <= p < top, in other words if p is within the region's currently allocated part (as opposed to the unallocated tail, if any).
Right, we should check that as well. Done in new commit, but I have to re-run the tests now, because something might trigger on this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20492#discussion_r1717345515
More information about the hotspot-gc-dev
mailing list