RFR: 8337981: ShenandoahHeap::is_in should check for alive regions [v3]

[Aleksey Shipilev]

On Wed, 14 Aug 2024 18:31:32 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8337981-shenandoah-is-in
>>  - Even stronger is_in check
>>  - Use is_in_reserved
>>  - Drop raw_referent to HeapWord*
>>  - Add some overrides
>>  - Merge branch 'master' into JDK-8337981-shenandoah-is-in
>>  - Style touchups
>>  - Fixing ShenandoahReferenceProcessor
>>  - Verifier fix
>>  - Fix
>
> src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp line 214:
> 
>> 212: 
>> 213:   ShenandoahHeapRegion* obj_reg = heap->heap_region_containing(obj);
>> 214:   if (!heap->is_full_gc_move_in_progress() && !obj_reg->is_active()) {
> 
> This is essentially ShenandoahHeap::is_in(), right? Might also want to check for obj < region->top() here? Or use is_in() to begin with?

All right, true. We might just use `is_in` here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20492#discussion_r1721629410