RFR: 8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small [v2]

Albert Mingkun Yang ayang at openjdk.org
Mon Aug 26 13:22:03 UTC 2024


On Thu, 22 Aug 2024 04:01:44 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The tests CollectorPolicy.* checks SerialGC policy. They might fail if MaxHeapSize is too small.
>> 
>> If heap is not enough for then VM change ergonomic scheme and print warning about this. The test is not checking this case.
>> The GC ergonomic has very different cases and only main workflow is covered. The goal of fix is not to improve test but pass in reasonable environment or silently pass if other.
>> 
>> I have updated test so it pass if heap is at least 128M (since it is SerialGC, it seems reasonable for testing in smaller containers) or skipped otherwise. 
>> 
>> Testing: tier1, running these tests manually with 90/128/256M to check that they pass in such environment.
>
> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - increased heap
>  - fixed space.
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8258483
>  - typo fixed.
>  - size updated.
>  - gtest has been updated.

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20656#pullrequestreview-2260668385


More information about the hotspot-gc-dev mailing list