RFR: 8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully [v2]

[Thomas Schatzl]

On Tue, 10 Dec 2024 11:04:09 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/gc/shared/genArguments.cpp
>>   
>>   Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
>
> src/hotspot/share/gc/shared/genArguments.cpp line 43:
> 
>> 41: // together with NewSize, is used to derive them.
>> 42: // Using the same value when it was a configurable flag to avoid breakage.
>> 43: // See more in JDK-8345323
> 
> I do not like referrals to the bug tracker in the code, and/or referring to some code the past ("when it was configurable").
> Better explicitly state the problem with heap sizing and large pages and file a follow-up RFE (not mentioning it here).

I.e. something like "If the default value of OldSize is too small, then ..., leading to the generations not aligned and not being able to allocate large pages" or so.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22575#discussion_r1877892382