RFR: 8337995: ZUtils::fill uses std::fill_n

Julian Waters jwaters at openjdk.org
Wed Dec 11 06:06:36 UTC 2024


On Tue, 10 Dec 2024 16:37:43 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to zUtils.cpp to use a for-loop to fill a block of
> memory rather than using the std::fill_n algorithm. Use of <algorithm> is
> currently not permitted in HotSpot.
> 
> Testing: mach5 tier1

I wonder how this even got in...

Windows/ARM64 also uses forbidden C++ Standard Library utilities, namely in the atomic implementation. I was thinking about fixing that, but I'm unsure of whether its use is truly needed and justified or not, and additionally Windows/Zero also uses the same atomic header as well

Sorry I meant orderAccess, not atomic

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22667#pullrequestreview-2494392701
PR Comment: https://git.openjdk.org/jdk/pull/22667#issuecomment-2533714318
PR Comment: https://git.openjdk.org/jdk/pull/22667#issuecomment-2533715955


More information about the hotspot-gc-dev mailing list