RFR: 8345659: Fix broken alignment after ReservedSpace splitting in GC code

Stefan Karlsson stefank at openjdk.org
Wed Dec 11 10:55:37 UTC 2024


On Wed, 11 Dec 2024 10:16:04 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> I wonder if doing the same for first_part makes it more symmetric/readable.

I think it is unclear if that would help readability or not. The `first_part` reserved space has the same base as the `heap_rs`, so it is kind of natural that it inherits the alignment from `heap_rs`. To me it seems somewhat redundant to explicitly specifying `HeapAlignment` again. Any other reviewers that prefer one or the other way?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22602#issuecomment-2535512786


More information about the hotspot-gc-dev mailing list