RFR: 8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully [v3]

Thomas Schatzl tschatzl at openjdk.org
Fri Dec 13 08:54:36 UTC 2024


On Wed, 11 Dec 2024 15:05:50 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> This patch reverts the default value of `OldSize` to its previous setting prior to being obsoleted in [JDK-8333962](https://bugs.openjdk.org/browse/JDK-8333962). The change addresses an issue where `OldSize` being set to zero results in a default `MinHeapSize` that is too small to handle LargePages correctly. This problem is exemplified by `ParallelArguments::initialize_heap_flags_and_sizes`, as identified in [JDK-8345323](https://bugs.openjdk.org/browse/JDK-8345323).
>> 
>> Changing the default value of `OldSize` may have broader implications due to the complexity of the logic that determines default values for various flags. Altering one default can lead to cascading effects and potential breakages elsewhere. For these reasons, this patch restores the previous default value of `OldSize` to mitigate such risks.
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refer to the new ticket

lgtm

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22575#pullrequestreview-2501755780


More information about the hotspot-gc-dev mailing list