RFR: 8343782: G1: Use one G1CardSet instance for multiple old gen regions [v4]

Ivan Walulya iwalulya at openjdk.org
Fri Dec 13 12:12:37 UTC 2024


On Fri, 13 Dec 2024 09:24:07 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1CollectionSetCandidates.cpp line 38:
>> 
>>> 36: { }
>>> 37: 
>>> 38: void G1CSetCandidateGroup::add(G1HeapRegion* hr) {
>> 
>> I believe this method is only for retained regions; if so, one can make that explicit by naming it sth like `add_region_region`.
>
> (Probably `add_retained_region` was meant here?)

Currently, we are using the method for adding young regions too

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22015#discussion_r1883841995


More information about the hotspot-gc-dev mailing list