RFR: 8345732: Provide helpers for using PartialArrayState [v3]

Kim Barrett kbarrett at openjdk.org
Tue Dec 17 17:15:39 UTC 2024


On Tue, 17 Dec 2024 15:18:28 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge branch 'master' into pa-splitter
>>  - rename splitter.step() => claim()
>>  - simplify comments
>>  - Merge branch 'master' into pa-splitter
>>  - parallel uses PartialArraySplitter
>>  - g1 uses PartialArraySplitter
>>  - add PartialArraySplitter
>>  - add PartialArrayTaskStats
>
> src/hotspot/share/gc/shared/partialArraySplitter.hpp line 46:
> 
>> 44: 
>> 45: public:
>> 46:   explicit PartialArraySplitter(PartialArrayStateManager* manager,
> 
> Why `explicit` for a method that has two args.

Forgot to remove when 2nd argument added.  Originally that number from the manager, but
a potentially long-lived and reused manager with dynamic selection of worker threads made
that wrong.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22622#discussion_r1888914756


More information about the hotspot-gc-dev mailing list