RFR: 8345732: Provide helpers for using PartialArrayState [v3]

[Kim Barrett]

On Tue, 17 Dec 2024 15:17:04 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge branch 'master' into pa-splitter
>>  - rename splitter.step() => claim()
>>  - simplify comments
>>  - Merge branch 'master' into pa-splitter
>>  - parallel uses PartialArraySplitter
>>  - g1 uses PartialArraySplitter
>>  - add PartialArraySplitter
>>  - add PartialArrayTaskStats
>
> src/hotspot/share/gc/shared/partialArrayTaskStats.hpp line 96:
> 
>> 94: 
>> 95: template<typename StatsAccess>
>> 96: void PartialArrayTaskStats::log_set(uint num_stats,
> 
> Can this be merged with its declaration? Seems kind of odd that these duplicates (method signature) are next to each other.

That would implicitly declare it inline, which doesn't seem particularly
desirable here.  And it doesn't seem worth the overhead of splitting out into
a .inline.hpp file.  (That would let the logging includes be moved there,
rather than here in the .hpp file.  But that seems like a small benefit, since
I don't think there are going to be *that* many includes of this file.)

But the implicit inlining probably doesn't really matter after all, since the
access function is probably different in every use, so we'll so we'll have 1-1
uses to instantiations anyway.  So sure, merging.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22622#discussion_r1888942745