RFR: 8345732: Provide helpers for using PartialArrayState [v4]

Albert Mingkun Yang ayang at openjdk.org
Wed Dec 18 18:25:37 UTC 2024


On Wed, 18 Dec 2024 16:56:45 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/partialArrayTaskStats.hpp line 90:
>> 
>>> 88:   // title: A string title for the table.
>>> 89:   template<typename StatsAccess>
>>> 90:   static void log_set(uint num_stats, StatsAccess access, const char* title) {
>> 
>> Going through all its call sites, I believe `print_stats` is more readable.
>
> The name log_set was chosen to suggest that it does "UL logging", and to
> indicate that it is for dealing with a set of stats objects.  I think
> print_stats loses both of those cues and is less clear because of that.

Why is "set" more than important than "stats" in "set of stats objects"? If "UL logging" is critical, "log_stats" would be better. When I first read this name, I thought it's related to "set" as in "getter/setter" of log...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22622#discussion_r1890642530


More information about the hotspot-gc-dev mailing list