RFR: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java

[Stefan Karlsson]

On Fri, 20 Dec 2024 11:33:48 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> JTREG=JAVA_OPTIONS=-XX:+NeverActAsServerClassMachine
> 
> test/hotspot/jtreg/gc/TestPLABAdaptToMinTLABSize.java
> java.lang.RuntimeException: Unexpected to get exit value of [0]
> 
> test/hotspot/jtreg/gc/g1/pinnedobjs/TestPinnedHumongousFragmentation.java
> # Internal Error (/home/azul/azul/openjdk-git/src/hotspot/share/prims/whitebox.cpp:2647), pid=1672170, tid=1672189
> # Error: ShouldNotReachHere()
> 
> test/hotspot/jtreg/gc/g1/pinnedobjs/TestPinnedObjectContents.java
> # Internal Error (/home/azul/azul/openjdk-git/src/hotspot/share/prims/whitebox.cpp:2647), pid=1672170, tid=1672189
> # Error: ShouldNotReachHere()

Changes requested by stefank (Reviewer).

test/hotspot/jtreg/gc/TestPLABAdaptToMinTLABSize.java line 72:

> 70: 
> 71:     public static void main(String[] args) throws Exception {
> 72:         for (String gc : Arrays.asList("-XX:+UseG1GC", "-XX:+UseParallelGC")) {

I think this could be problematic if you compile out G1 or Parallel. I would suggest that you create two separate run blocks. One for G1 and one for Parallel, and then pass in the GC to test through the `args`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22847#pullrequestreview-2517573704
PR Review Comment: https://git.openjdk.org/jdk/pull/22847#discussion_r1893951737