RFR: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled [v5]

[Wang Zhuo]

On Thu, 1 Feb 2024 11:26:25 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Wang Zhuo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update test
>
> test/hotspot/jtreg/gc/parallel/TestAlwaysPreTouchBehavior.java line 83:
> 
>> 81:         System.out.println("cannot get RSS, just skip");
>> 82:         return; // Did not get avaiable RSS, just ignore this test
>> 83:     }
> 
> The `EXCEPTION_VALUE` constant seems superfluous, and the marked code can be simplified to just
> 
> Suggestion:
> 
>     } catch (Exception e) {
>         System.out.println("cannot get RSS, just skip");
>         return; // Did not get avaiable RSS, just ignore this test
>     }
> 
> 
> imo.
> 
> Actually, thinking a bit further, I think there is no reason to actually try to catch anything here. If the `proc` filesystem isn't readable (or something changes in its contents) I would think it is worth looking at the environment or fixing the test.

Thanks, EXCEPTION_VALUE  related code were deleted. Test updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17610#discussion_r1475476782