RFR: 8324649: Shenandoah: refactor implementation of free set [v6]

[Kelvin Nilsen]

On Thu, 1 Feb 2024 02:28:32 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename and comments for _capacity_of and _used_by
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 68:
> 
>> 66: 
>> 67:   // For each partition p, _capacity[p] represents the total amount of memory within the partition at the time
>> 68:   // of the most recent rebuild, _used[p] represents the total amount of memory that has been consumed within this
> 
> instead of consumed, can we just say used (or allocated)?

Replaced.  Thanks.

> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 112:
> 
>> 110:   // In other words:
>> 111:   //   if the requested which_partition is empty:
>> 112:   //     leftmost() and leftmost_empty() return _max, rightmost() and rightmost_empty() return 0
> 
> There are mutually contradictory statements in the highlighted portion of the documentation above. I suspect the earlier reference to -1 is obsolete and needs to be deleted.

Good catch.  Thank you.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1476883719
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1476884451