RFR: 8324649: Shenandoah: refactor implementation of free set [v6]

[Kelvin Nilsen]

On Sat, 3 Feb 2024 15:46:04 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 761:
>> 
>>> 759: void ShenandoahFreeSet::prepare_to_rebuild(size_t &cset_regions) {
>>> 760:   shenandoah_assert_heaplocked();
>>> 761:   // This resets all state information, removing all regions from all partitions.
>> 
>> I thought it makes them all unavailable, placing them all into the NotFree partition.
>
> The wording has been a bit imprecise, possibly made even worse by some global search and replaces on free-set and partition.  I've tried to clarify in most recent draft that we consider Collector and Mutator to be partitions, but the NotFree labels means "not in a partition".  Maybe you can help me find the right wording here...

I'm adjusting this comment in hopes of making the intent more clear.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1477087368