RFR: 8324995: Shenandoah: Skip to full gc for humongous allocation failures [v3]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Feb 7 16:26:54 UTC 2024
On Wed, 31 Jan 2024 21:50:06 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Shenandoah degenerated cycles do not compact regions. When a humongous allocation fails, it is likely due to fragmentation which is better addressed by a full gc.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix typo in comment
src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 490:
> 488: bool is_humongous = words > ShenandoahHeapRegion::humongous_threshold_words();
> 489:
> 490: if (try_set_alloc_failure_gc(is_humongous)) {
I think we can replace this with assert(words <= ShenandoahHeapRegion::humongous_ghreshold_words()
We do not evacuate humongous objects.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17638#discussion_r1481751566
More information about the hotspot-gc-dev
mailing list