RFR: 8324649: Shenandoah: refactor implementation of free set [v6]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Feb 7 18:39:10 UTC 2024
On Thu, 1 Feb 2024 05:22:21 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename and comments for _capacity_of and _used_by
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 50:
>
>> 48: const size_t _max; // The maximum number of heap regions
>> 49: const size_t _region_size_bytes;
>> 50: const ShenandoahFreeSet* _free_set;
>
> Interesting: why does the partitioning need a reference to its containing free set?
There are a few places where ShenandoahRegionPartitions invokes services provided by ShenandoahFreeSet, such as calling _free_set->alloc_capacity() when enforcing certain assertions and when adjusting interval boundaries.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1481922483
More information about the hotspot-gc-dev
mailing list