RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM [v2]

Aleksey Shipilev shade at openjdk.org
Wed Feb 21 10:37:55 UTC 2024


On Wed, 21 Feb 2024 10:23:38 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> src/hotspot/share/gc/shenandoah/shenandoahLock.cpp line 39:
> 
>> 37: class ShenandoahNoBlockOp : public StackObj {
>> 38: public:
>> 39:   ShenandoahNoBlockOp(JavaThread* java_thread) {
> 
> Should this be inline? Or would compiler be clever enough to not emit anything there?
> Edit: or doesn't it matter, because we are going to yield anyway?

I don't think it matters, because the actual yield would dominate. Also, I don't think we do `inline` for RAII constructors...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17813#discussion_r1497282609


More information about the hotspot-gc-dev mailing list