RFR: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode

Thomas Schatzl tschatzl at openjdk.org
Fri Feb 23 08:58:54 UTC 2024


On Fri, 16 Feb 2024 00:44:24 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Allow TEST_VM_FLAGLESS to enable/disable flagless tests execution explicitly.
> Sometimes the tests are executed in the mode that is incompatible with flag-sensitive tests. This mode should be able to disable them explicitly.

Marked as reviewed by tschatzl (Reviewer).

test/jtreg-ext/requires/VMProps.java line 668:

> 666:         boolean result = true;
> 667:         if (System.getenv("TEST_VM_FLAGLESS") != null) {
> 668:             return "" + "true".equalsIgnoreCase(System.getenv("TEST_VM_FLAGLESS"));

I would slightly prefer extracting the `System.getenv()` call into a local and reusing it, but this is fine as well.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17886#pullrequestreview-1897641915
PR Review Comment: https://git.openjdk.org/jdk/pull/17886#discussion_r1500370050


More information about the hotspot-gc-dev mailing list