RFR: 8326763: Consolidate print methods in ContiguousSpace

Stefan Karlsson stefank at openjdk.org
Tue Feb 27 10:01:53 UTC 2024


On Tue, 27 Feb 2024 09:46:50 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Trivial inlining and removing some unused methods.

Changes requested by stefank (Reviewer).

src/hotspot/share/gc/shared/space.cpp line 110:

> 108: }
> 109: 
> 110: void ContiguousSpace::print() const { print_on(tty); }

It is a common pattern in HotSpot to have a `print()` function that delegates to `print_on(tty)`. I think this function should be kept.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18022#pullrequestreview-1903054254
PR Review Comment: https://git.openjdk.org/jdk/pull/18022#discussion_r1503959557


More information about the hotspot-gc-dev mailing list