RFR: 8326763: Consolidate print methods in ContiguousSpace

Guoxiong Li gli at openjdk.org
Wed Feb 28 15:12:14 UTC 2024


On Tue, 27 Feb 2024 09:46:50 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Trivial inlining and removing some unused methods.

Looks good.

src/hotspot/share/gc/shared/space.cpp line 105:

> 103: 
> 104: void ContiguousSpace::print_on(outputStream* st) const {
> 105:   st->print_cr(" space %zuK, %3d%% used [" PTR_FORMAT ", " PTR_FORMAT ", " PTR_FORMAT ")",

Why not use the previous `SIZE_FORMAT`?

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18022#pullrequestreview-1906262300
PR Review Comment: https://git.openjdk.org/jdk/pull/18022#discussion_r1506107028


More information about the hotspot-gc-dev mailing list