RFR: 8326688: Parallel: Remove unnecessary BOT update in UpdateOnlyClosure::do_addr

Thomas Schatzl tschatzl at openjdk.org
Thu Feb 29 08:05:51 UTC 2024


On Mon, 26 Feb 2024 15:46:50 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple removing redundant BOT updates for non-moved objs.
> 
> Test: tier1-3

src/hotspot/share/gc/parallel/psParallelCompact.cpp line 2554:

> 2552: 
> 2553: inline void UpdateOnlyClosure::do_addr(HeapWord* addr) {
> 2554:   _start_array->update_for_block(addr, addr + cast_to_oop(addr)->size());

The change looks reasonable. Instead of the update, would it be possible to do verification in debug mode?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18008#discussion_r1507163431


More information about the hotspot-gc-dev mailing list