RFR: 8326612: Parallel: remove redundant assertion from ScavengeRootsTask

[Thomas Schatzl]

On Sat, 24 Feb 2024 09:29:20 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> This change removes a redundant assertion from `ScavengeRootsTask`.
> The assertion is redundant because `_old_gen` is initialized to `old_gen` at L296 which is dereferenced at L297 before the assertion is reached.

Since `old_gen` is already dereferenced in the initializer list, the code would already crash before reaching this assert anyway, so it is useless.

You do need to file a CR and fix the title though until this can be moved along.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17994#pullrequestreview-1908220960
PR Comment: https://git.openjdk.org/jdk/pull/17994#issuecomment-1970620649