RFR: 8326975: Parallel: Remove redundant PSOldGen::is_allocated [v2]

Albert Mingkun Yang ayang at openjdk.org
Thu Feb 29 10:04:06 UTC 2024


On Thu, 29 Feb 2024 08:09:08 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/parallel/psParallelCompact.cpp line 873:
> 
>> 871:     return false;
>> 872:   }
>> 873: 
> 
> In principle this acts an assert, so maybe either adding one, or a comment like "// Memory reservation must have been successful if we reach here" would maybe be nice. Or renaming this method as `initialize_aux[iliary]_data` or something would already indicate that this code is not supposed to initialize everything.

Renamed and added an assertion that heap should be reserved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18047#discussion_r1507313555


More information about the hotspot-gc-dev mailing list