RFR: 8320864: Serial: Extract out Full GC related fields from ContiguousSpace [v5]
Stefan Johansson
sjohanss at openjdk.org
Mon Jan 8 12:14:24 UTC 2024
On Tue, 2 Jan 2024 08:56:03 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Simple moving some fields from the generic class to Full GC specific files.
>>
>> Ideally, on deciding wheter `to`-space should be compacted, one should use `set_incremental_collection_failed` to check if promotion-failure occurred during young-gc, but in some places, this flag is set even in the absence of promotion-failure, e.g. `heap->set_incremental_collection_failed(); // Slight lie: we did not even attempt one`. Therefore, I used `next_compaction_space` for this purpose, in order to keep this patch more focused and the diff-size small.
>>
>> Test: tier1-5; perf neutral using the attached benchmark.
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
> s1-full-gc
Nice cleanup, looks good.
-------------
Marked as reviewed by sjohanss (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16842#pullrequestreview-1808965525
More information about the hotspot-gc-dev
mailing list