RFR: 8323066: gc/g1/TestSkipRebuildRemsetPhase.java fails with 'Skipping Remembered Set Rebuild.' missing

Albert Mingkun Yang ayang at openjdk.org
Mon Jan 8 16:35:24 UTC 2024


On Mon, 8 Jan 2024 16:17:15 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   the test is too sensitive to the amount of allocation, using an arbitrary value of `G1MixedGCLiveThresholdPercent`. This caused random test failures depending on how objects were allocated after GC in old gen, and the amount of allocations during startup.
> 
> Using a value of 0 should guarantee that no old region will ever be selected for rebuild, resulting in the correct expected message.
> 
> Testing: local testing of test case, gha
> 
> Thanks,
>   Thomas

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17309#pullrequestreview-1809557448


More information about the hotspot-gc-dev mailing list