RFR: 8234502: Merge GenCollectedHeap and SerialHeap [v9]

Albert Mingkun Yang ayang at openjdk.org
Tue Jan 9 16:30:27 UTC 2024


On Tue, 9 Jan 2024 15:52:46 GMT, Lei Zaakjyu <duke at openjdk.org> wrote:

>> 8234502: Merge GenCollectedHeap and SerialHeap
>
> Lei Zaakjyu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
> 
>  - resolve conflicts
>  - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8234502
>  - fix import statement
>  - fix import statement
>  - remove 'GenCollectedHeap' from 'jdk.hotspot.agent'
>  - resolve conflict
>  - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8234502
>  - restore comment
>  - line-break for EOF
>  - merge 'CollectedHeap' and 'SerialHeap'

Running testing now. The patch mostly looks good.

src/hotspot/share/gc/shared/vmStructs_gc.hpp line 174:

> 172:   declare_toplevel_type(ContiguousSpace*)                                 \
> 173:   declare_toplevel_type(DefNewGeneration*)                                \
> 174:   declare_toplevel_type(Generation*)                                      \

Can these two *Generation be removed also? (They are specific to Serial, while this file is for "shared".)

-------------

PR Review: https://git.openjdk.org/jdk/pull/16927#pullrequestreview-1811525103
PR Review Comment: https://git.openjdk.org/jdk/pull/16927#discussion_r1446315896


More information about the hotspot-gc-dev mailing list