RFR: 8323005: Parallel: Refactor PSPromotionManager::claim_or_forward_depth [v2]

[Richard Reingruber]

On Thu, 4 Jan 2024 16:11:31 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple refactoring to inline certain checks to the callee.
>> 
>> Test: use card_scan.java from https://bugs.openjdk.org/browse/JDK-8310031 to stress young-gc and pause time stays the same.
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   pgc-push-depth

src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp line 59:

> 57: template <class T>
> 58: inline void PSPromotionManager::claim_or_forward_depth(T* p) {
> 59:   assert(should_scavenge(p, true), "revisiting object?");

While working on [JDK-8310031](https://bugs.openjdk.org/browse/JDK-8310031) this assertion helped to find bugs quite a few times. It might be worth keeping it at line 62.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17267#discussion_r1447057844