RFR: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME

Thomas Schatzl tschatzl at openjdk.org
Wed Jan 10 10:00:33 UTC 2024


On Tue, 9 Jan 2024 17:01:05 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this change that removes the obsolete and ever-problemlisted `gc/stress/TestGCLocker*` tests.
>> 
>> The test tries to verify JNI by filling the heap, causing GCs, but always OOME'ing because the parameters to tune this behavior are too hard to get right for every case and every collector.
>> 
>> GCLocker functionality is already being tested with other tests like gc/TestJNICriticalStressTest, gc/cslocker/TestCSLocker, vmTestbase/gc/lock/*, other tests that incidentally use JNI and collector specific JNI tests (e.g. gc/g1/pinnedObjs/*).
>> 
>> Fwiw, the test also fails when replacing the JNI code by equivalent Java code i.e. not causing gclocker gcs.
>> 
>> Given all this I think removing these tests is just fine.
>> 
>> Thanks,
>>   Thomas
>
> Marked as reviewed by lmesnik (Reviewer).

Thanks @lmesnik @albertnetymk for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17322#issuecomment-1884527045


More information about the hotspot-gc-dev mailing list