RFR: 8314480: Memory ordering spec updates in java.lang.ref [v4]

[Viktor Klang]

On Tue, 12 Dec 2023 23:36:30 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Classes in the `java.lang.ref` package would benefit from an update to bring the spec in line with how the VM already behaves. The changes would focus on _happens-before_ edges at some key points during reference processing.
>> 
>> A couple key things we want to be able to say are:
>> - `Reference.reachabilityFence(x)` _happens-before_ reference processing occurs for 'x'.
>> - `Cleaner.register()` _happens-before_ the Cleaner thread runs the registered cleaning action.
>> 
>> This will bring Cleaner in line (or close) with the memory visibility guarantees made for finalizers in [JLS 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
>> _"There is a happens-before edge from the end of a constructor of an object to the start of a finalizer (§12.6) for that object."_
>
> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add links to new Memory Consistency section in package doc

src/java.base/share/classes/java/lang/ref/Reference.java line 499:

> 497:      * the reference is removed from the queue by {@link ReferenceQueue#poll}
> 498:      * or {@link ReferenceQueue#remove}. An <b><i>unsuccessful</i></b>
> 499:      * {@code enqueue} call has no memory consistency effects.

Would it help to say that unsuccessful enqueue calls have no *reliable* or *specified* memory consistency effects?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1447602550