RFR: 8321512: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java fails on 32-bit platforms

[Aleksey Shipilev]

On Tue, 23 Jan 2024 10:46:59 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this fix for a failing test on 32 bit platforms. In particular, for the `G1CardSetArray` card set container the existing code tries to optimize memory usage by changing the number of entries (`G1RemSetArrayOfCardsEntries`, each entry taking 2 bytes) so that the resulting memory usage is 8 bytes aligned (because the allocator used aligns to 8 bytes anyway, so why not use that space).
> 
> On 32 bit platforms, the calculation results in an invalid size (> 2^16).
> 
> The suggested fix removes this automatic container size optimization: it is only used for the rare case when the knowledgeable user modifies the defaults; in that case I propose to have the user worry about optimal usage of the memory too, and simplify the code.
> 
> Testing: failing test passes
> 
> Thanks,
>   Thomas

Looks good to me.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17532#pullrequestreview-1838464264