RFR: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out

[David Holmes]

On Tue, 23 Jan 2024 02:30:26 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Simple fix to add an explicit timeout to these tests.
>> 
>> See JBS for discussion.
>> 
>> Testing: ran the updated tests through our CI 10x on each platform
>> 
>> Thanks
>
> The fix looks good. Might be makes sense to test that this timeout is enough for slowest combination like fastdebug + Xomp and diffferent GCs. But we could check it in CI.
> Update: This testing is already done.

Thanks for the reviews @lmesnik  and @shipilev .

> Might be makes sense to test that this timeout is enough for slowest combination like fastdebug + Xomp and diffferent GCs.

@lmesnik  you are right. I only tested this under normal conditions (as it timed out for me under normal conditions locally). I need to run it under higher-tier CI conditions too. Just need to figure out how without running full tiers ...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17524#issuecomment-1907487827