RFR: 8324636: Serial: Remove Generation::block_is_obj
Y. Srinivas Ramakrishna
ysr at openjdk.org
Wed Jan 24 21:59:29 UTC 2024
On Wed, 24 Jan 2024 21:09:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> > Please ensure that the header file documentation isn't lost because of this change.
>
> The doc is in `SerialHeap::block_is_obj`, the actual public API.
It would be good to have documentation in the header file of the highest supertype that exposes the API, rather than having to look at the callers of that API and their API documentation to impute that information. That said, I'll leave it up to you to decide if that is sufficiently persuasive to replicate the documentation and make it more maintainable.
Reviewed!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17555#issuecomment-1908980940
More information about the hotspot-gc-dev
mailing list