RFR: 8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64

[Thomas Schatzl]

On Thu, 25 Jan 2024 16:07:11 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1RegionPinCache.inline.hpp line 42:
>> 
>>> 40: inline void G1RegionPinCache::dec_count(uint region_idx) {
>>> 41:   if (region_idx == _region_idx) {
>>> 42:     --_count;
>> 
>> I think _count should never underflow here.  Consider adding an assertion.
>
> I think you are correct if you change the default value of the region idx to `HRM_REGION_IDX`. Let me try this.

It's `G1_NO_HRM_INDEX`....

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17552#discussion_r1466620937