RFR: 8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64 [v2]

[Thomas Schatzl]

On Thu, 25 Jan 2024 16:55:15 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> It was meant similarly to the call to `_g1h->verifier()->check_region_attribute_table()` call to verify post conditions for that GC phase.
>> Putting it right after `JavaThreadRetireTLABAndFlushLogs` seems too close to the change to kind of make it kind of redundant - i.e. that task is small enough to understand it at a glance anyway (well, me at least).
>> 
>> Thinking again, it might be most useful to put this into a method (like mentioned `check_region_attribute_table`) and call it there to be able to use it elsewhere during debugging if needed.
>> 
>> Of course, we can also just remove this - what do you think?
>
> Removing it is better, IMO.

Removed the super-cautious assert.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17552#discussion_r1467405792